Feat: add OCS routes for mailbox and mail listing#11425
Conversation
|
Thanks for opening your first pull request in this repository! ✌️ |
janepie
force-pushed
the
feat/add-ocs-inbox-route
branch
2 times, most recently
from
f459cda to
ba32a24
Compare
janepie
force-pushed
the
feat/add-ocs-inbox-route
branch
from
ba32a24 to
04063bb
Compare
janepie
force-pushed
the
feat/add-ocs-inbox-route
branch
5 times, most recently
from
cf675c2 to
4d368a7
Compare
| $userId, | ||
| $view | ||
| ); | ||
| return new DataResponse(json_encode($messages), Http::STATUS_OK); |
There was a problem hiding this comment.
json_encode should not be necessary when using DataResponse, I think 🤔
There was a problem hiding this comment.
You're right, removed :)
janepie
force-pushed
the
feat/add-ocs-inbox-route
branch
5 times, most recently
from
89f3d55 to
bb06df5
Compare
| * 200: Mailbox list | ||
| * 404: User was not logged in or account doesn't exist | ||
| */ | ||
| #[ApiRoute(verb: 'GET', url: '/mailbox/list')] |
There was a problem hiding this comment.
Nitpick: not happy about the URL design. /api/mailboxes is already taken by the internal API. How about /api/ocs/mailboxes or similar to have a new, dedicated sub path for public ocs APIs?
There was a problem hiding this comment.
The api/ part is left out for the OCS routes for now, but I'm open to anything here. Could put ocs instead of api, so /ocs/mailboxes/list?
There was a problem hiding this comment.
I'm fine with leaving out the api part for ocs. But please make it ocs/mailboxes without the list
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
janepie
force-pushed
the
feat/add-ocs-inbox-route
branch
from
bb06df5 to
a76eb7a
Compare
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
janepie
force-pushed
the
feat/add-ocs-inbox-route
branch
from
a76eb7a to
f6b793d
Compare
Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com> Signed-off-by: janepie <49834966+janepie@users.noreply.github.com>
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
3 participants
adds OCS routes to